Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/ag-grid): allow overriding grid min-height #3077

Merged
merged 4 commits into from
Jan 31, 2025
Merged

fix(components/ag-grid): allow overriding grid min-height #3077

merged 4 commits into from
Jan 31, 2025
+29 −0

Conversation

johnhwhite
Copy link
Member

@johnhwhite johnhwhite commented Jan 29, 2025 •
edited by azure-boards bot
Loading

@johnhwhite johnhwhite added the risk level (author): 1 No additional bugs expected from this change label Jan 29, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9ac5692.

Command Status Duration Result
nx affected --target lint test posttest --confi... ✅ Succeeded 1m 8s View ↗
nx affected --target build postbuild lint test ... ✅ Succeeded 2m 31s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-31 13:04:46 UTC

@blackbaud-sky-build-user
Copy link
Collaborator

Storybook preview

Component Storybooks:

Apps:

@johnhwhite
Merge remote-tracking branch 'origin/11.x.x' into ag-grid-min-height-…
0506bde 
…option

* origin/11.x.x:
  chore(code-examples): add skyux-eslint as an implicit dependency to the code-examples app (#3085)
  fix(components/datetime): add missing harness exports  (#3079)
@johnhwhite
Add test
9ac5692
@johnhwhite johnhwhite merged commit b9b6c7d into 11.x.x Jan 31, 2025
24 checks passed
@johnhwhite johnhwhite deleted the ag-grid-min-height-option branch January 31, 2025 14:29
blackbaud-sky-build-user pushed a commit that referenced this pull request Jan 31, 2025
@johnhwhite
fix(components/ag-grid): allow overriding grid min-height (#3077)
88a7a49 
[AB#3239244](https://dev.azure.com/blackbaud/f565481a-7bc9-4083-95d5-4f953da6d499/_workitems/edit/3239244)
@blackbaud-sky-build-user
Copy link
Collaborator

Cherry-pick successful! 🍒 🎉 See #3088

This was referenced Jan 31, 2025
Merged
Draft
johnhwhite added a commit that referenced this pull request Jan 31, 2025
@blackbaud-sky-build-user @johnhwhite
fix(components/ag-grid): allow overriding grid min-height (#3077) (#3088
20670ca 
)

🍒 Cherry picked from #3077 [fix(components/ag-grid): allow
overriding grid
min-height](#3077)


[AB#3239244](https://dev.azure.com/blackbaud/f565481a-7bc9-4083-95d5-4f953da6d499/_workitems/edit/3239244)

Co-authored-by: John White <[email protected]>
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Jan 31, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackbaud-ErikaMcVey Blackbaud-ErikaMcVey Blackbaud-ErikaMcVey approved these changes

Assignees

@Blackbaud-ErikaMcVey Blackbaud-ErikaMcVey

Labels
risk level (author): 1 No additional bugs expected from this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnhwhite @blackbaud-sky-build-user @Blackbaud-ErikaMcVey