Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add as review ls #610

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

kenstir
Copy link

@kenstir kenstir commented Dec 20, 2024

Fixes #609

  • Add as review ls --id=appid to list reviews. For now, it uses a simple
    text output that is readable in the terminal.

* Sort reviews by date descending
* Print using fmt.Printf not log.Info, so it is readable in the
  terminal
and print (responded) if we responded.
* Add `--after` to limit reviews by date
* Use sort=-createdDate so we don't have to sort
* Use include=response and print body of review if we haven't responded
* Add `--since` to limit reviews by duration
* Exit 2 if no reviews to aid scripting
@blacktop
Copy link
Owner

are there going to be other sub-cmds other than ls ?

@kenstir
Copy link
Author

kenstir commented Dec 24, 2024

are there going to be other sub-cmds other than ls ?

No I don't think so. I just started using that cmd "in anger" yesterday, and I'm using it to email me a list of all reviews in the last 24h.

for appid in $app1 $app2 $app3; do
    ipsw appstore review ls --since '25h' --id $appid
done

But it's not helpful to list apps by app ID so I think I want another command app ls to list apps, so I could do

for appid in `ipsw appstore app ls --show=appid`; do
    ...

I see there is already an unused function GetApps() so I would start there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add appstore review command
2 participants