Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add OpTransaction conversion tests #1939

Merged
merged 5 commits into from
Dec 24, 2024
Merged

test: add OpTransaction conversion tests #1939

merged 5 commits into from
Dec 24, 2024

Conversation

hoank101
Copy link
Contributor

@hoank101 hoank101 commented Dec 21, 2024 •
edited by rakita
Loading

Test conversion of OpTransaction

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 21, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1939 will not alter performance

Comparing hoank101:test/1894 (fe6cb1d) with main (e3f6a35)

Summary

✅ 8 untouched benchmarks

rakita
rakita approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@rakita rakita left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test, lgtm. Lets remove the panic ones.

Will change Issue name and description as it test only small part of op

@rakita rakita changed the title test: add test revm-optimism test: add OpTx conversion tests Dec 23, 2024
@rakita rakita changed the title test: add OpTx conversion tests test: add OpTransaction conversion tests Dec 23, 2024
@hoank101
Copy link
Contributor Author

Good test, lgtm. Lets remove the panic ones.

Will change Issue name and description as it test only small part of op

thank you for feedback, I just updated the code

@hoank101 hoank101 requested a review from rakita December 23, 2024 14:19
@rakita rakita merged commit 716ebea into bluealloy:main Dec 24, 2024
28 checks passed
This was referenced Dec 24, 2024
Closed
Closed
@hoank101 hoank101 deleted the test/1894 branch December 24, 2024 11:23
This was referenced Dec 24, 2024
Open
Open
Open
Closed
Open
This was referenced Dec 31, 2024
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Open
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita Awaiting requested review from rakita

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoank101 @rakita