-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major update - added strict types, added code quality tools #4
base: master
Are you sure you want to change the base?
Conversation
Hey @indy2kro , many thanks for your contribution. As already said in your other PR, it will take some time to be able to check all the changes you squeezed in this single PR. Again, I can just recommend providing smaller PRs, because that helps in getting code merged quickly and efficiently. |
Well, this one is .. basically a re-write of the app. I understand your request, but the truth is there is so much changed it's easier to just consider a review from scratch or just to keep it as a separate fork. |
Keep in mind, that making small codebases "more professional" by introducing more tools and rules (like you would do in an enterprise project) sometimes adds a lot of overhead to simple pragmatic things. I will check it as soon as I find some time. |
Major update, modernize tool, contains breaking changes from previous version.