Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update - added strict types, added code quality tools #4

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

indy2kro
Copy link

Major update, modernize tool, contains breaking changes from previous version.

  • Dropped support for php versions older than PHP 8.2 (not compatible with all changes)
  • Added Rector support
  • Added PHPinsights support
  • Added PHPstan support
  • Updated PHPstan to level 9
  • Added strict_types to all files
  • Updated github actions to use caching, added more tools execution
  • Split class in multiple files to reduce complexity
  • Added more tests

@bluemoehre
Copy link
Owner

Hey @indy2kro , many thanks for your contribution.

As already said in your other PR, it will take some time to be able to check all the changes you squeezed in this single PR. Again, I can just recommend providing smaller PRs, because that helps in getting code merged quickly and efficiently.

@indy2kro
Copy link
Author

Well, this one is .. basically a re-write of the app. I understand your request, but the truth is there is so much changed it's easier to just consider a review from scratch or just to keep it as a separate fork.

@bluemoehre
Copy link
Owner

Keep in mind, that making small codebases "more professional" by introducing more tools and rules (like you would do in an enterprise project) sometimes adds a lot of overhead to simple pragmatic things.

I will check it as soon as I find some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants