Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release catchup #8

Merged
merged 37 commits into from
Jan 15, 2025
Merged

Conversation

ES-Alexander
Copy link
Collaborator

@ES-Alexander ES-Alexander commented Dec 19, 2024

🔎 PREVIEW 🔍

Documents:

Minimally documents:

@ES-Alexander ES-Alexander force-pushed the release-catchup branch 2 times, most recently from a220780 to 7943eda Compare December 20, 2024 12:02
@ES-Alexander ES-Alexander force-pushed the release-catchup branch 6 times, most recently from 4e7398b to 5c71a27 Compare January 2, 2025 13:57
@ES-Alexander ES-Alexander force-pushed the release-catchup branch 3 times, most recently from 65ab35e to fc1ec38 Compare January 2, 2025 16:12
@ES-Alexander ES-Alexander force-pushed the release-catchup branch 7 times, most recently from dbea2b1 to 365f2b5 Compare January 8, 2025 06:51
@ES-Alexander ES-Alexander marked this pull request as ready for review January 8, 2025 10:36
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments about things I think can improved, but I'm approving already because this is already ULTRA good and should be shared with the world.

Great work Eliot!

content/usage/installation.md Show resolved Hide resolved
content/usage/getting-started/index.md Outdated Show resolved Hide resolved
1. A sidebar menu icon
- Normally a sidebar tab arrow on the left
- Can be configured as a burger menu in the top left corner

### Header Bar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be interesting to mention that both bars can be configured to be hidden and/or toggled with a Cockpit Action.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried that action and couldn't get it to work for the top bar - the bottom bar one works fine though.

content/usage/advanced/index.md Outdated Show resolved Hide resolved
content/usage/advanced/index.md Outdated Show resolved Hide resolved
content/usage/advanced/index.md Outdated Show resolved Hide resolved
content/usage/advanced/index.md Outdated Show resolved Hide resolved
Comment on lines +607 to +623
While other widgets generally have predefined behaviour, these are specifically designed to trigger and
set variables for use as parameters in [Custom HTTP Actions](#custom-actions).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They actually set variables in the data-lake, and so can be used in any Actions (or other places like external widgets, DIY widgets, etc).

Comment on lines +723 to +743
If the browser tab is changed away from Cockpit, or the Cockpit application window is minimised,
Cockpit loses access to the joystick inputs, and normally stops sending `MANUAL_CONTROL` messages
to reflect the loss of input. This can trigger an autopilot failsafe, which may not be desirable,
so an option is provided in the top right of the joystick page to tell Cockpit to repeatedly send
the last joystick input it received before losing access to the joystick.
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be interesting to mention that one can avoid this kind of problem by having only the Cockpit tab in a given window and opening other tabs in another browser window.

It can also be avoided by using the self-contained version and not minimizing it (can be out of focus without a problem).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are somewhat implied as-is, and seem out of scope of that warning to include specific details of.

- `mavlink_disarm`

#### Custom Actions
It is also possible to define (and export or import) your own custom Actions, with a few different approaches:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be interesting to mention where the data-lake variables can be used on those actions (anywhere in a javascript action, on the parameters and body of a http action or in the message of a mavlink action).

@ES-Alexander ES-Alexander force-pushed the release-catchup branch 3 times, most recently from 5b72272 to 15b84ba Compare January 15, 2025 23:36
@ES-Alexander ES-Alexander merged commit 26e9dde into bluerobotics:latest Jan 15, 2025
1 check passed
@ES-Alexander ES-Alexander deleted the release-catchup branch January 15, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants