Remove dependency on the gamepad.js library
#1524
Draft
+166
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
remove-gamepad-lib
branch
4 times, most recently
from
bbf1b3d to
c606b28
Compare
rafaellehmkuhl
force-pushed
the
remove-gamepad-lib
branch
from
c606b28 to
545c6af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library adds less than 100 lines of code while obfuscating the native usage of the Gamepad API and hiding part of the code.
This hidden parts can be responsible for bugs, like the one we see regarding gamepads not being detected after sometime of inactivity.
To ease this and future debugs, as well as future implementations regarding the usage of virtual gamepads and native access on the Electron app, the library is removed and replaced with native code.