Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotter: Allow setting number of decimal places to be displayed #1566

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Jan 13, 2025

This way variables in units like lat/long or radians can show correctly, instead of just being cropped or appearing as 0.00.

@rafaellehmkuhl rafaellehmkuhl force-pushed the allow-setting-number-of-digits-plotter branch from 3140a04 to b93ae1e Compare January 14, 2025 20:22
@rafaellehmkuhl
Copy link
Member Author

@ES-Alexander if you could review this one as well, it allows the user to specify the number of digits, which helps with values like 0.0012345 or coordinates.

Copy link
Contributor

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine :-)

I do think it could be nice to have the Data Point controls in a single line, instead of two rows, e.g.

[Decimal places] || [ ] Limit samples [Maximum samples]

but up to you 🤷

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Jan 15, 2025

Seems to work fine :-)

I do think it could be nice to have the Data Point controls in a single line, instead of two rows, e.g.

[Decimal places] || [ ] Limit samples [Maximum samples]

but up to you 🤷

Will change before merging.

@rafaellehmkuhl rafaellehmkuhl force-pushed the allow-setting-number-of-digits-plotter branch from b93ae1e to cbada48 Compare January 15, 2025 16:20
@rafaellehmkuhl rafaellehmkuhl merged commit 410a482 into bluerobotics:master Jan 15, 2025
11 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the allow-setting-number-of-digits-plotter branch January 15, 2025 16:45
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jan 16, 2025
@ES-Alexander ES-Alexander added docs-in-progress Included in an open docs PR docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented docs-in-progress Included in an open docs PR labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-complete Change documentation has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants