-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes #1587
Minor fixes #1587
Conversation
I'm not sure how to fix that failed test - it's a linter check that's failing on the contents of a string, which it shouldn't even be looking at 🤷 |
You should add a |
4726d37
to
41f2bb4
Compare
@patrickelectric that doesn't seem to have helped (or at least it hasn't stopped the linter from complaining) |
92dc6d3
to
8e82d7c
Compare
0991543
to
3b71386
Compare
3b71386
to
e978582
Compare
e978582
to
d8a4497
Compare
@ES-Alexander for the next contributions it would be good to separate those commits in different PRs, as they are not related, so they appear correctly on the changelog. |
docs:
|
Ahh, I'm used to wanting a nice commit history, but hadn't considered that the PR history is also valuable to keep clean for repos that have releases (docs don't so it's not really important). I would have been happy to split this out into separate PRs if you'd requested that before merging, but no worries - I'll keep it in mind for in future :-) |
Fixes #1572
Fixes #1560
Fixes #557