Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #1587

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Minor fixes #1587

merged 3 commits into from
Jan 17, 2025

Conversation

ES-Alexander
Copy link
Contributor

@ES-Alexander ES-Alexander commented Jan 17, 2025

Fixes #1572
Fixes #1560
Fixes #557

@ES-Alexander
Copy link
Contributor Author

I'm not sure how to fix that failed test - it's a linter check that's failing on the contents of a string, which it shouldn't even be looking at 🤷

@patrickelectric
Copy link
Member

I'm not sure how to fix that failed test - it's a linter check that's failing on the contents of a string, which it shouldn't even be looking at 🤷

You should add a v-pre to avoid being rendered by vue.

@ES-Alexander ES-Alexander force-pushed the smol-fixes branch 2 times, most recently from 4726d37 to 41f2bb4 Compare January 17, 2025 09:55
@ES-Alexander
Copy link
Contributor Author

ES-Alexander commented Jan 17, 2025

You should add a v-pre to avoid being rendered by vue.

@patrickelectric that doesn't seem to have helped (or at least it hasn't stopped the linter from complaining)

@ES-Alexander ES-Alexander force-pushed the smol-fixes branch 2 times, most recently from 92dc6d3 to 8e82d7c Compare January 17, 2025 10:38
@ES-Alexander ES-Alexander marked this pull request as draft January 17, 2025 10:53
@ES-Alexander ES-Alexander force-pushed the smol-fixes branch 4 times, most recently from 0991543 to 3b71386 Compare January 17, 2025 12:14
@ES-Alexander ES-Alexander marked this pull request as ready for review January 17, 2025 12:21
@rafaellehmkuhl rafaellehmkuhl merged commit 01b7c21 into bluerobotics:master Jan 17, 2025
11 checks passed
@rafaellehmkuhl
Copy link
Member

@ES-Alexander for the next contributions it would be good to separate those commits in different PRs, as they are not related, so they appear correctly on the changelog.

@ES-Alexander ES-Alexander deleted the smol-fixes branch January 17, 2025 16:06
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jan 17, 2025
@ES-Alexander
Copy link
Contributor Author

docs:

  • top bar toggle Action
  • JavaScript Custom Action editor screenshot

@ES-Alexander
Copy link
Contributor Author

@ES-Alexander for the next contributions it would be good to separate those commits in different PRs, as they are not related, so they appear correctly on the changelog.

Ahh, I'm used to wanting a nice commit history, but hadn't considered that the PR history is also valuable to keep clean for repos that have releases (docs don't so it's not really important). I would have been happy to split this out into separate PRs if you'd requested that before merging, but no worries - I'll keep it in mind for in future :-)

@ES-Alexander ES-Alexander added docs-in-progress Included in an open docs PR docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented docs-in-progress Included in an open docs PR labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-complete Change documentation has been completed
Projects
None yet
3 participants