-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flask login #18
base: master
Are you sure you want to change the base?
Flask login #18
Conversation
return AuthResponse("Username or Password was incorrect"), 404 | ||
|
||
login_user(user) | ||
return AuthResponse(message="logged in"), 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnorquist, which syntax do you want to use? I see a mixture of
AuthResponse('Username or Password was incorrect')
AuthResponse(message='logged in')
Let's standardize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnorquist this mixture is still across the codebase, which syntax do you prefer?
else: | ||
config = DevelopmentConfig() | ||
# initialize dev database here? | ||
environment = os.environ.get("ENVIRONMENT") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnorquist, this is ready to be merged in but I think once you stashed the changes you also removed changing this from ENVIRONMENT
to FLASK_ENV
todo:
python -c 'import os; print(os.urandom(16))'
to generate one