Fix ShippingLines.Id type #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbtb1982
force-pushed
the
fix-shipping-lines-id-type
branch
from
7834a6e to
d6c9461
Compare
bbtb1982
force-pushed
the
fix-shipping-lines-id-type
branch
from
d6c9461 to
55f317e
Compare
|
Checking in on this PR. not sure who needs to be contacted. Please let me know how I can help push this though. |
oliver006
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update ShippingLines.Id to string from uint64
Why
While querying the AbandonedCheckout endpoint the resulting response from shopify rest api . the Id is not a number but a string. Thus throwing an error while unmarshaling the records.