Preserve visualizer types across nested sink nodes #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently type visualizers are associated with either data types or operator types. Operator-type specific visualizers are automatically propagated through subject nodes, disabled nodes or empty group nodes, but not within any other reactive operators.
This PR extends this implicit propagation specifically to
Sinkgroup nodes.Sinknodes implicitly create an internal subject to allow their nested logic to be handled without changing the original sequence. Implicit propagation of visualizer assignments throughSinknodes would allow for example simple transformation of GUI element notifications before multicasting the data through subjects elsewhere in the workflow.Fixes #1742