Ensure Dequeue is not attempted if buffer size is 0 #1876
Conversation
There was a problem hiding this comment.
My original intent here was that bufferSize should always be greater than 0, I just didn't enforce it robustly enough.
A better approach I think would be to just enforce that, IE: Replace
bonsai/Bonsai.Design/ObjectTextVisualizer.cs
Line 167 in a9dd431
with
bufferSize = Math.Max(1, (int)((textBox.ClientSize.Height - 2) / lineHeight));That way if the buffer size would've been 0, there's always at least a single entry kept around so it appears when the user resizes the form.
(As it's written right now there's also other places assuming bufferSize is non-zero too so they'd still be broken too.)
| @@ -37,7 +37,7 @@ protected override void ShowBuffer(IList<Timestamped<object>> values) | |||
| var sb = new StringBuilder(); | |||
|
|
|||
| // Trim old values if bufferSize was reduced | |||
| while (buffer.Count >= bufferSize) | |||
| while ((buffer.Count >= bufferSize) & (buffer.Count > 0)) | |||
There was a problem hiding this comment.
Should be &&, which would also make these groupings unnecessary
|
Sounds good! Feel free to edit the PR directly or just open a new one! Thanks for looking into it! |
|
Created #1882 (there was one other small change that was needed so it was a good thing I took a closer look.) |
Closes #1875