Log all unhandled bootstrapper exceptions #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During release automation development we realized that unhandled exceptions in the bootstrapper might still be swallowed by the main process, e.g. due to assembly resolution failures. This was fixed in #1873 but with the side-effect that multiple exception traces would now be printed for console bootstrapper package resolution errors, since exceptions were also being routed and printed by the internal bootstrapper console logger.
This PR simplifies error handling to let all exceptions from the console bootstrapper surface naturally, while simultaneously preventing stack trace complexity by flattening the most common case where the
AggregateExceptioncontains a single inner exception.Fixes #1804