Rename CombineTimestamp to CreateTimestamped #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
added
feature
bruno-f-cruz
approved these changes
Jul 30, 2024
PathogenDavid
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CombineTimestampoperator was introduced in one of the earliest releases of the language as a way to create timestamped values dynamically from pairs of values and timestamps. As a consequence of this early development, the naming of this operator does not follow current naming conventions.This PR refactors
CombineTimestampinto the newCreateTimestampedoperator, for consistency with other creation operators and withCreateTimestampedused in the Harp package. Core proxy types have been leveraged to allow for automatic conversion of old workflows and the original type has been marked with the[Obsolete]attribute.Fixes #1518