Add MatrixWriter overload for sequences of unmanaged types #2110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the compatibility of
MatrixWriter
to any arbitrary sequence of unmanaged types by taking advantage ofBuffer.MemoryCopy
to directly marshal the value type into a binary stream.The new overload signature is:
Buffer.MemoryCopy
is compatible across both .NET Framework and .NET 5+ but we might consider later improving the implementation for .NET 5+ by taking advantage of new memory copy performance primitives.Fixes #1578