Added source node capabilities to StateComponent #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
requested changes
May 10, 2024
Comment on lines
+81
to
+83
| /// <summary> | ||
| /// Given an observable sequence, this function returns an observable sequence of state components for each element in the input sequence | ||
| /// /// </summary> |
There was a problem hiding this comment.
Suggested change
| /// <summary> | |
| /// Given an observable sequence, this function returns an observable sequence of state components for each element in the input sequence | |
| /// /// </summary> | |
| /// <summary> | |
| /// Given an observable sequence, this function returns an observable sequence of state | |
| /// components for each element in the input sequence. | |
| /// </summary> |
Duplicate /// and minor formatting
Comment on lines
+95
to
+97
| /// <summary> | ||
| /// This function returns an observable sequence of state components | ||
| /// /// </summary> |
There was a problem hiding this comment.
Suggested change
| /// <summary> | |
| /// This function returns an observable sequence of state components | |
| /// /// </summary> | |
| /// <summary> | |
| /// Returns an observable sequence of state components. | |
| /// </summary> |
Comment on lines
+12
to
+14
| [Description("State component of a Kalman Filter")] | ||
| [Combinator()] | ||
| [WorkflowElementCategory(ElementCategory.Source)] |
There was a problem hiding this comment.
Suggested change
| [Description("State component of a Kalman Filter")] | |
| [Combinator()] | |
| [WorkflowElementCategory(ElementCategory.Source)] | |
| [Combinator] | |
| [Description("State component of a Kalman Filter")] | |
| [WorkflowElementCategory(ElementCategory.Source)] |
|
I'm going to close this PR as addressed in #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the StateComponent class in the LinearDynamicalSystems package to function also as a source node