Fix/1452 #1977
Open
Fix/1452 #1977
+271
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
reviewed
Jan 14, 2025
dellaert
reviewed
Jan 14, 2025
| */ | ||
| int main() { | ||
| // Path to the test data file | ||
| ifstream infile("IncrementalFixedLagSmootherTestData.txt"); |
There was a problem hiding this comment.
Could you load the file as in the test I provided in this branch?
dellaert
reviewed
Jan 14, 2025
| saveG2oGraph(smoother.getFactors(), currentEstimate, path + "isam", lineCount); | ||
| infile.close(); | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Add a new line at end of file, please
|
You’re merging this into the branch I created, which added this as a unit test. I don’t think we need both, so could you also delete the test in this PR? Also look at how I load the file, and perhaps how I now use |
…eading files and adding factors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a minimal test case of
IncrementalFixedLagSmootheringtsam/gtsam_unstable/examplesfolder using real-world data to showcase how settingfindUnusedFactorSlots = trueaddresses the issue #1452 in GTSAM.