Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: fix typos #105

wants to merge 1 commit into from

Conversation

kianmeng
Copy link

@kianmeng kianmeng commented Dec 24, 2023

Found via codespell -L nd

nd
and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a false positive.

nd
and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

nd
and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"nd"

@kianmeng kianmeng force-pushed the fix-typos branch 2 times, most recently from de988b0 to feadffd Compare December 24, 2023 16:00
@kianmeng kianmeng requested a review from szepeviktor December 24, 2023 16:01
nd
and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we still correct "nd".

# our code introduced WARNING logs due to git commit from issued to GEnerator
# our code introduced WARNING logs due to git commit from issued to GGenerator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may need a fix.

# the below allows URL resolutoin, same as in prod, (ie same bug should appear, if syntax error in user yaml)
# the below allows URL resolutions, same as in prod, (ie same bug should appear, if syntax error in user yaml)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be plural.

Comment on lines 1086 to 1088
splitted = path.split(relative_path)
split = path.split(relative_path)

if splitted[0] == '':
if split[0] == '':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can lead to arguing.

Comment on lines -98 to +97
# Pytest pluging usually declare their public API in fixtures.py
# Pytest plugin usually declare their public API in fixtures.py

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"plugins", see "declare their"

@@ -27,7 +27,7 @@
# ie: if we scaffold new Project at /data/my-project/README.md, /data/my-project/src
# then GEN_PROJ_LOC = /data/my-project
GEN_PROJ_LOC = os.path.realpath(os.path.curdir)

If we compares three flowers as pictured below

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This non-comment line popped up here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy this line into DeepL Write: https://www.deepl.com/write

Found via `codespell -L nd`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants