fix using invalidated iterator

bostick · Oct 29, 2024 · a819331 · a819331
1 parent b59c7b6
commit a819331
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/tablature.cpp b/lib/tablature.cpp
@@ -1008,10 +1008,15 @@ TtbtFileTablature(const tbt_file_t &t) {
                 barLineWidth = 1;
             }
 
+            //
+            // save this because barLinesMap may be modified later and invalidate barLinesMapIt
+            //
+            bool barLinesMapItIsEnd = (barLinesMapIt == barLinesMap.end());
+
             //
             // bar line (when processed BEFORE the space)
             //
-            if (barLinesMapIt != barLinesMap.end()) {
+            if (!barLinesMapItIsEnd) {
 
                 if constexpr (0x70 <= VERSION) {
 
@@ -1356,7 +1361,7 @@ TtbtFileTablature(const tbt_file_t &t) {
             //
             // bar line (when processed AFTER the space)
             //
-            if (barLinesMapIt != barLinesMap.end()) {
+            if (!barLinesMapItIsEnd) {
 
                 if constexpr (0x70 <= VERSION) {