Use explicit function param

botify-hq · Sep 28, 2017 · 115e0d0 · 115e0d0
1 parent eb68ebd
commit 115e0d0
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 21 deletions.
diff --git a/packages/react-scripts/config/botifyConfig.js b/packages/react-scripts/config/botifyConfig.js
@@ -3,24 +3,6 @@
 const autoprefixer = require('autoprefixer');
 const ExtractTextPlugin = require('extract-text-webpack-plugin');
 
-const postCssOptions = {
-  // Necessary for external CSS imports to work
-  // https://github.com/facebookincubator/create-react-app/issues/2677
-  ident: 'postcss',
-  plugins: () => [
-    require('postcss-flexbugs-fixes'),
-    autoprefixer({
-      browsers: [
-        '>1%',
-        'last 4 versions',
-        'Firefox ESR',
-        'not ie < 9', // React doesn't support IE8 anyway
-      ],
-      flexbox: 'no-2009',
-    }),
-  ],
-};
-
 const getSCSSLoaderConfig = isDev => {
   const loaders = [
     {
@@ -29,7 +11,23 @@ const getSCSSLoaderConfig = isDev => {
     },
     {
       loader: require.resolve('postcss-loader'),
-      options: postCssOptions,
+      options: {
+        // Necessary for external CSS imports to work
+        // https://github.com/facebookincubator/create-react-app/issues/2677
+        ident: 'postcss',
+        plugins: () => [
+          require('postcss-flexbugs-fixes'),
+          autoprefixer({
+            browsers: [
+              '>1%',
+              'last 4 versions',
+              'Firefox ESR',
+              'not ie < 9', // React doesn't support IE8 anyway
+            ],
+            flexbox: 'no-2009',
+          }),
+        ],
+      },
     },
     require.resolve('sass-loader'),
   ];
@@ -50,7 +48,7 @@ const getSCSSLoaderConfig = isDev => {
   };
 };
 
-module.exports = (isDev = true) => ({
+module.exports = ({ isDev = true } = {}) => ({
   babelPlugins: [require.resolve('babel-plugin-transform-decorators-legacy')],
   webpackLoaders: [getSCSSLoaderConfig(isDev)],
 });
diff --git a/packages/react-scripts/config/webpack.config.prod.js b/packages/react-scripts/config/webpack.config.prod.js
@@ -23,7 +23,7 @@ const ModuleScopePlugin = require('react-dev-utils/ModuleScopePlugin');
 const paths = require('./paths');
 const getClientEnvironment = require('./env');
 const getBotifyConfig = require('./botifyConfig');
-const botifyConfig = getBotifyConfig(false);
+const botifyConfig = getBotifyConfig({ isDev: false });
 
 // Webpack uses `publicPath` to determine where the app is being served from.
 // It requires a trailing slash, or the file assets will get an incorrect path.