female coder collector #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the problem is the image on the female coder website is in "webp" format and when I ingested the collector on my local, it could not respond any image. |
kadhonn
reviewed
Apr 25, 2024
| val eventUrls = mutableListOf<String>() | ||
| val document = Jsoup.parse(fetcher.fetchUrl(baseUrl)) | ||
|
|
||
| document.select("div.et_pb_section_3 .event_details") |
There was a problem hiding this comment.
it is fine as it is, but you could rewrite this forEach loop with a .map operation
then it would look something like
val eventUrls = document.select("div.et_pb_section_3 .event_details")
.map {
it.select("a").first().attr("href")
}
| val currentYear = LocalDate.now().year | ||
|
|
||
| val localDate = LocalDate.parse("$date $currentYear", DateTimeFormatter.ofPattern("MMMM dd yyyy", Locale.ENGLISH)) | ||
| val localStartTime = LocalTime.parse(startTime.uppercase(Locale.getDefault()), DateTimeFormatter.ofPattern("hh:mm a")) |
There was a problem hiding this comment.
please do not use Locale.getDefault(), use english or german
kadhonn
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #346