a11y: change page title #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadhonn
reviewed
Apr 30, 2024
| @@ -14,7 +14,7 @@ import org.springframework.web.servlet.ModelAndView | |||
| @RequestMapping("/") | |||
| class StartPageController @Autowired constructor(private val eventService: EventService) { | |||
|
|
|||
| private val PAGE_TITLE = "Boudicca" | |||
| private val PAGE_TITLE = "Boudicca.Events - Open source event collector and publisher software" | |||
There was a problem hiding this comment.
hmm
do we want to focus on events or on our software here? i think the former, so i would focus on that
something mentioning more our loval events, or accessibility or something like that
There was a problem hiding this comment.
Boudicca.event - find accessible events in austria ?
kadhonn
reviewed
May 1, 2024
| @@ -14,7 +14,7 @@ import org.springframework.web.servlet.ModelAndView | |||
| @RequestMapping("/") | |||
| class StartPageController @Autowired constructor(private val eventService: EventService) { | |||
|
|
|||
| private val PAGE_TITLE = "Boudicca.Events - Open source event collector and publisher software" | |||
| private val PAGE_TITLE = "Boudicca.Event - find accessible events in Austria" | |||
There was a problem hiding this comment.
the page is still called "Boudicca.Events", but the additional text looks fine for me
kadhonn
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses part of # 414
https://www.w3.org/WAI/WCAG21/Understanding/page-titled.html