Fix or delete examples #2811
Merged
Fix or delete examples #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The orszag-tang example allocates a field in the monitor. Writing before the monitor is called therefore causes a segfault.
Useful for allowing chaining of assignment and attributes, tidies up physics model code writing output variables.
Uses the new output system, rather than storing pointers. Should help avoid segfaults and uninitialised variables.
Build directory should contain a data/ subdirectory so that running "blob2d" without arguments runs ok. Copy the blob_velocity analysis script.
Quantities can be written to output with attributes like units and conversion factors.
The sod-shock case runs, but I don't think the parameters are right. The rayleigh-taylor case doesn't run. Not enough grid cells for unclear reason.
Unused restart_format
|
Suggestions for deletion:
Move to separate repos?
|
We should not push people to start learning old stuff.
Save phi to output using `outputVars` method. Add `override` keywords.
Removing unused variables, changing output writing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* next: (111 commits) Apply clang-format changes Remove commented out code Improve comment prefer std::equal Remove propietary data Be more verbose by default Explicitly set -std=c++17 for --cflags Apply clang-format changes use std::optional<size_t> Add more OpenMP comments Add comments on OpenMP + mutex Fix escaping Remove python2 compatibility rename getDefaultRegion to getValidRegionWithDefault Apply clang-format changes Fix test-twistshift-staggered FieldFactory: Use string matching for options Apply clang-format changes Boolean expressions: Allow "True" and "False" again Apply clang-format changes ...
Co-authored-by: David Bold <[email protected]>
Co-authored-by: David Bold <[email protected]>
Co-authored-by: David Bold <[email protected]>
Remove `backtrace` example, move into docs instead
dschwoerer
previously approved these changes
Mar 14, 2024
dschwoerer
force-pushed
the
fix-examples
branch
from
af797d5 to
cf966c8
Compare
|
(sorry, I did a bad merge, and then a force push to fix it.) |
|
I have a fix for fci-wave in my db-outer branch, but that will require some of my other open PRs to work ... |
ZedThree
force-pushed
the
fix-examples
branch
from
9012307 to
924ca0a
Compare
ZedThree
force-pushed
the
fix-examples
branch
from
924ca0a to
5fe6896
Compare
|
Failing test is some problem with fedora packages |
* next: (146 commits) CMake: Replace include SourceRuns with SourceCompiles Fix typos in laplacian inversion documentation (credit @MigMadeira) Arkode solver: Change adap_method to an enum class Arkode solver: Add treatment enum, remove imex/implicit/explicit arkode solver: Clang format Deleted the last line Removed ASSERT1 Update src/solver/impls/arkode/arkode.cxx Update src/solver/impls/arkode/arkode.cxx Update src/solver/impls/arkode/arkode.cxx Update src/solver/impls/arkode/arkode.cxx changed ARKODE config. to use string as the treatment include fmt/ranges.h for using fmt::join() mark fmt::format() const Add mxorder option back, now deprecated Apply clang-format changes Solver: Ensure nonlinear RHS called first Add CVODE version guard CVODE solver: Pass linear flag to rhs() Imex issue is resolved ...
…ch next-options-nocopy.
Use reference to Options (not a copy). Required since changes in branch next-options-nocopy.
Some more examples fixes
This was referenced Sep 18, 2024
Closed
ZedThree
approved these changes
Oct 23, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
Aiming to clean up the examples, to ensure that they all work. I think the number of examples should also be reduced, either by deleting them or moving them to a separate repository.
We should also have little test in each example, that at least ensures that the example builds and runs a short step.