Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate options that are only used as default for other options #3038

Merged
merged 10 commits into from
Jan 21, 2025

Conversation

dschwoerer
Copy link
Contributor

See #3036 for motivation

This can be confusing if both options are used, then one is effectively
silently ignored.
This has been done using the bout-upgrader, using this command:
bout-upgrader v6 input -f $(git ls-tree -r HEAD|grep inp\$|awk '{print $4}')
This has been done using the bout-upgrader, using this command:
bout-upgrader v6 input -f $(git ls-tree -r HEAD|grep inp\$|awk '{print $4}')

This time with a fix for boutproject/boutdata#120
@dschwoerer dschwoerer changed the title Deprecate options that only use as default for other options Deprecate options that are only used as default for other options Dec 4, 2024
Copy link
Contributor

@bendudson bendudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dschwoerer !

@bendudson bendudson merged commit ed20d19 into next Jan 21, 2025
26 of 28 checks passed
@bendudson bendudson deleted the deprecation-hidden-default-option branch January 21, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants