cherab interface: Calculate heat fluxes to walls #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`xbout.wall.AxisymmetricWall` represents an axisymmetric wall
`xbout.wall.read_geqdsk` reads a GEQDSK file, returning an AxisymmetricWall
`xbout.cherab.triangulate.TriangularData.wall_flux`
takes an AxisymmetricWall and calculates heat fluxes to each element.
So to calculate heat fluxes:
```
wall = xbout.wall.read_geqdsk("geqdsk")
ds = ds.bout.with_cherab_grid()
da = -bd['Rd+_ex'].isel(t=1, zeta=0)
da[:2,:] = 0.0
da[-2:,:] = 0.0
data = da.bout.as_cherab_data()
result = data.wall_flux(cat_wall, pixel_samples=1000)
```
|
Hello @bendudson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-12-11 06:37:51 UTC |
TomNicholas
reviewed
Dec 11, 2024
| """ | ||
| return np.stack((self.Rs, self.Zs), axis=-1) | ||
|
|
||
| def plot(self, linestyle="k-", ax=None): |
There was a problem hiding this comment.
FYI I think plotting the wall onto the plasma is analogous to plotting features like coastlines using cartopy onto the earth.
There might be useful inspiration from how cartopy interacts with matplotlib, especially if you want to set up presets for a small number of possible wall shapes (there are only so many tokamaks in the world).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xbout.wall.AxisymmetricWallrepresents an axisymmetric wallxbout.wall.read_geqdskreads a GEQDSK file, returning an AxisymmetricWallxbout.cherab.triangulate.TriangularData.wall_fluxtakes an AxisymmetricWall and calculates heat fluxes to each element.So to calculate heat fluxes: