Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update exception file get download URL #866

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix: Update exception file get download URL #866

merged 2 commits into from
Jan 19, 2024

Conversation

congminh1254
Copy link
Member

@congminh1254 congminh1254 commented Jan 18, 2024 •
edited
Loading

Closes: SDK-3474

I'm using the BoxException not BoxAPIException because normally, the BoxAPIException will parse from response body but not any custom exception.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7569455181

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 93.536%
Totals Coverage Status
Change from base Build 7556215294: 0.005%
Covered Lines: 3473
Relevant Lines: 3713
💛 - Coveralls

@congminh1254 congminh1254 merged commit 94dcbcd into main Jan 19, 2024
13 checks passed
@congminh1254 congminh1254 deleted the fix-download-url branch January 19, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszsocha2 lukaszsocha2 lukaszsocha2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congminh1254 @coveralls @lukaszsocha2