add other time in force types to order details #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyan-soubachov
requested changes
Feb 19, 2019
tastyworks/models/order.py
Outdated
| @dataclass | ||
| class OrderDetails(object): | ||
| type: OrderType = None | ||
| time_in_force: str = 'Day' | ||
| time_in_force: TimeInForce = TimeInForce.DAY | ||
| gtc_date: str = None |
There was a problem hiding this comment.
Could we store this as a datetime? I think it would make a lot more sense to API users if they don't have to parse the string themselves.
There was a problem hiding this comment.
👍 Good call, updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem addressed
The problem/issue addressed by this PR is #8. Adding more time in force options like GTC and GTD.
Solution
Added a time-in-force Enum property to the OrderDetails object. Also add a gtc-date which is only relevant when using the GTD option. Made sure to check the payload the tastyworks api send when using this time in force option.
Checklist