watchlists

[bandwiches]

Problem addressed

Watchlists

Solution

• Migrated to new API
• Increased scope to include custom watchlists as well as public watchlists
• Created checks for instability in Tastyworks API data
  • Some watchlists return instrument-type, instrument_type or they do not return anything.
  • Some watchlists do not return a group-name
  • New API does not return a slug

Checklist

• PR commits have been squashed
• All tests pass
• Code adheres to contributing guidelines

[bandwiches]

#55

[bandwiches]

I also added support & tests for symbol search in this update (Reference: #50). I chose not to remove the dough module just yet, here's my reasoning.

• The Dough API and Tastyworks API both have symbol_search endpoints
• Dough API is deprecated
  • I have no historical data of what this endpoint used to return
• Tastyworks API seems like it's reusing the name for a new process

Based on the code for the dough module, it seems like it used to return a lot more than it does now. Because of this, I have added support for market-metrics in its own module, but chose to exclude it from this PR.

If you think it would be good to include that, I can commit and push. The tally at that point would be [3] Features as opposed to [2].

Features in this commit:

• Watchlists (public & custom)
• Symbol Search

Optional Features awaiting commit:

• Market Metrics

[boyan-soubachov]

Thank you very much for you time and submission 🙂 🙏 . I've left a few comments if you don't mind addressing? Please let me know if you'd like to discuss them

[bandwiches]

@boyan-soubachov Am I finally ready? 😆

[boyan-soubachov]

Looks great. Thanks for all your hard work :) Merging