-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue #1042 #2778
Fixes issue #1042 #2778
Conversation
PR is in conflict with PR #2775. |
Ok, will solve the conflicts later. |
Done |
Cool. Merged. Thanks. |
It also fixes #2452 |
@Phi-Hung-1007 Can you please share a doc definition that we can use on the playground to reproduce the bug? Thanks. |
@fe-cj On the playgound, I use dontBreakRows to avoid breaking rowspan between two pages but still get it, it seems like version 2.0.13 is not applied on playground yet? Thanks |
On playground is latest version 0.2.13. |
@liborm85 So why can't I still use dontBreakRows for rowSpan like in the example above? |
|
I fixed an error that was adding extra height to the table when combining If you encounter a bug, it would be nice if you open an issue and share a doc definition that others can copy and paste in the playground. |
@Phi-Hung-1007 Again... If you found bug, open an issue with example code for reproduce problem runnable on playground or https://jsfiddle.net/ or a similar service, as is described in CONTRIBUTING.md. |
Fixes #1042
It was not calculating correctly the 'y' at the end of a rowSpan with dontBreakRows.