Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Template categories + search #18

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Template categories + search #18

merged 3 commits into from
Mar 28, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Mar 26, 2022

Replace options, including templates can now be optionally classified by category:

image

Also, an additional search meta-data allows to specify search terms not displayed through name, label or description.


Try it out via

npx @bpmn-io/sr bpmn-io/bpmn-js-connectors-extension#template-categories-search -c 'npm start'

Enable create/append anything modeling UX via a feature toggle.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 26, 2022
@nikku nikku force-pushed the improve-mouse-interaction branch from 7cfdc6d to b88885e Compare March 26, 2022 18:25
@nikku nikku force-pushed the template-categories-search branch from 9c3bedd to 59247c2 Compare March 26, 2022 18:26
@nikku nikku marked this pull request as ready for review March 26, 2022 18:29
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 26, 2022
@nikku nikku changed the title Template categories search Template categories + search Mar 26, 2022
@nikku
Copy link
Member Author

nikku commented Mar 28, 2022

@currandwyer I'd love to make basic grouping available to our users. Please have a look at this change and highlight and feedback potential improvements.

image

image

@currandwyer
Copy link

@nikku I think this looks great, particularly in this append anything context. I also expect that append anything is the direction of travel for our modeling UX, so this will be a nice feature to have. When this does happen, I suggest changing the title to "Append specialized element" or something like this, to be specific and precise about the purpose of the component.

I realize it's out of scope, but I think that adding the ability to filter would be nice to have alongside this.

I don't think it makes sense to launch categories until we have a higher number of specialized tasks to categorize. Categorizing the REST and SendGrid connectors is a lipstick on a pig solution. Rather than categorizing them, we should focus on shipping auth so that the auth configuration exists within the properties panel, as it should. Then we only have two connectors, not enough to categorize. In any case, the categories will work differently (for more higher order distinctions), and we mustn't confuse these different mental models so early on.

I think it is very important not to refer to connectors as templates. We must align on one word (whether it is connectors or integrations or whatever) to refer to these things. The element template is a part of the connector, but it's not the main thing. Introducing this additional technical language, which requires users to develop an understanding of our technical architecture, could be unnecessarily confusing.

@nikku
Copy link
Member Author

nikku commented Mar 28, 2022

Thanks for your comments, both of you.

I realize it's out of scope, but I think that adding the ability to filter would be nice to have alongside this.

Agreed @currandwyer.

I don't think it makes sense to launch categories until we have a higher number of specialized tasks to categorize.

Will see if we can get rid of the categories in the append connector scenario.

I think it is very important not to refer to connectors as templates.

Also agreed. We are free to choose whatever naming / group labels. We can either settle on "REST", "SendGrid" as generic names, not ship these names at all or incorporate template / connector as dedicated terms.

What would be your preference? We can both have a look and experiment later this week, too. @currandwyer

@nikku nikku force-pushed the improve-mouse-interaction branch 2 times, most recently from 5da9afe to 676c828 Compare March 28, 2022 11:19
@nikku nikku force-pushed the template-categories-search branch 3 times, most recently from 122e63a to 794d4bc Compare March 28, 2022 12:08
@nikku
Copy link
Member Author

nikku commented Mar 28, 2022

Updated to not show the category, unless provided in connectors mode:

image


Also updated the branch so it can be merged independently.

@nikku nikku changed the base branch from improve-mouse-interaction to master March 28, 2022 12:10
@nikku nikku mentioned this pull request Mar 28, 2022
@nikku nikku force-pushed the template-categories-search branch from 20bebe2 to 79563fa Compare March 28, 2022 12:59
nikku added 3 commits March 28, 2022 15:22
Allows us to override styles in the to-be-expected manner.
+ make header font-weight bolder as 500 often defaults to normal
+ slightly improve muted / template headings color
+ make colors + weight configurable
@nikku nikku force-pushed the template-categories-search branch from 79563fa to 762b354 Compare March 28, 2022 13:22
@nikku nikku merged commit b286bf7 into master Mar 28, 2022
@nikku nikku deleted the template-categories-search branch March 28, 2022 18:44
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants