Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C8 Template groups #564

Merged
merged 2 commits into from
Feb 3, 2022
Merged

C8 Template groups #564

merged 2 commits into from
Feb 3, 2022

Conversation

pinussilvestrus
Copy link
Contributor

Builds on top of #555.
Related to camunda/camunda-modeler#2673

image

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jan 28, 2022
@pinussilvestrus

This comment has been minimized.

@pinussilvestrus pinussilvestrus self-assigned this Jan 28, 2022
@pinussilvestrus pinussilvestrus mentioned this pull request Jan 28, 2022
8 tasks
@pinussilvestrus pinussilvestrus force-pushed the template-groups branch 2 times, most recently from f432c3a to 6a0c748 Compare January 31, 2022 18:47
@pinussilvestrus pinussilvestrus marked this pull request as ready for review January 31, 2022 18:49
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 31, 2022
@pinussilvestrus pinussilvestrus requested review from a team, philippfromme and MaxTru and removed request for a team January 31, 2022 18:49
Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a personal request ;-) Would it be possible to have an example for custom groups in the start script for cloud-templates? It makes fuzzy testing (for this PR, but also for future changes to come) so much easier

@MaxTru
Copy link
Contributor

MaxTru commented Jan 31, 2022

Also one thought:
Do we have an issue where we document the documentation updates that are necessary once we make this avaialble publically? Rationel I ask: I believe our existing docs are superb. I know we cannot update them now, since this feature is not yet supported / available public, but I would like to ensure that we document it in the used quality once we get to that point.

@pinussilvestrus
Copy link
Contributor Author

This is a personal request ;-) Would it be possible to have an example for custom groups in the start script for cloud-templates? It makes fuzzy testing (for this PR, but also for future changes to come) so much easier

Good catch, I added it accordingly. I already had an example in fixtures I used for testing, but didn't link it to the start script 👍

Also one thought:
Do we have an issue where we document the documentation updates that are necessary once we make this avaialble publically? Rationel I ask: I believe our existing docs are superb. I know we cannot update them now, since this feature is not yet supported / available public, but I would like to ensure that we document it in the used quality once we get to that point.

👍 I created an issue and linked it in the epic: camunda/camunda-modeler#2723

@MaxTru MaxTru mentioned this pull request Feb 2, 2022
Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature

@fake-join fake-join bot merged commit a84f8b0 into master Feb 3, 2022
@fake-join fake-join bot deleted the template-groups branch February 3, 2022 12:16
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants