Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text annotations to overlap with the borders of subprocesses and pools #2049

Closed
CatalinaMoisuc opened this issue Dec 7, 2023 · 5 comments · Fixed by #2078
Closed
Assignees
Labels
enhancement New feature or request modeling spring cleaning Could be cleaned up one day ux

Comments

@CatalinaMoisuc
Copy link
Member

CatalinaMoisuc commented Dec 7, 2023

Context

Transferred from: https://github.com/camunda/web-modeler/issues/7213.
cc @till-stadtler

Describe the problem that you are trying to solve

When adding or moving text annotations in a subprocess or a pool, it can happen that the border of the subprocess or pool is shifted. For me, this is often an undesired effect.

Text annotations can become hidden behind subprocesses.

This behavior of text annotations can lead to subprocesses and pools that are larger than they need to be in regards to the relevant BPMN elements themselves.

Describe the solution you'd like to see implemented

I would like text annotations to not affect the size of subprocesses or pools when adding or moving them around. This means they should be allowed to overlap with the borders of subprocesses and pools. (This already happens when the text annotation is "outside" the subprocess or pool. In this case, the text annotation becomes partially hidden. (This behavior is not consistent, regarding a text annotation being outside of a pool or not.))

Text annotations should always be visible, thus independent of the "scope" where they live in the XML (?).

I hope this change will allow BPMN processes to become more compact as it will be easier to shift text annotations to a desired location. Customers might choose to position text annotations outside of subprocesses or pools, which makes the BPMN process itself more compact, see below. Once this is implemented, a tool can be added to temporarily hide all text annotations to focus on the BPMN process itself.

To summarize, text annotations should be always on top and not affect resizing of the containers they are in.

Describe alternatives you've considered

Use ctrl + z to undo the undesired change.

Additional Context

Adding a text annotation:
new-text-annotation

Moved the text annotation a bit to the right:
moved-text-annotation

Partially hidden text annotation:
partially-hidden-text-annotation

I assume this requested handling of text annotations will lead the customers to design more compact in regards to relevant BPMN elements. Especially, if we implement a tool to temporarily hide text annotations. This way, text annotations do not heavily affect the size and compactness of the BPMN model.
compact-model

@CatalinaMoisuc CatalinaMoisuc added the enhancement New feature or request label Dec 7, 2023
@nikku
Copy link
Member

nikku commented Dec 7, 2023

Let's have a quick user feedback. Happy to make text annotations labels, behavior wise.

@nikku nikku added backlog Queued in backlog ready Ready to be worked on labels Dec 12, 2023 — with bpmn-io-tasks
@nikku nikku added spring cleaning Could be cleaned up one day and removed backlog Queued in backlog labels Dec 12, 2023
@till-stadtler
Copy link

Hi @nikku,
I got one positive feedback for this FR from @barmac!
Until now, no other person has responded to my Camunda-internal user feedback request.

@nikku
Copy link
Member

nikku commented Dec 13, 2023

I think it is a safe bet to try out regardless.

@barmac
Copy link
Member

barmac commented Dec 13, 2023

I think it's fair to expect that text annotations are displayed on top of everything, and don't affect the flow elements containers bounds.

@nikku
Copy link
Member

nikku commented Dec 19, 2023

I think it's fair to expect that text annotations are displayed on top of everything, and don't affect the flow elements containers bounds.

This is backed up by camunda/camunda-modeler#4035.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modeling spring cleaning Could be cleaned up one day ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants