Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Annotation of Bondary Event hidden behhind Sub-Process #4035

Closed
mschoe opened this issue Dec 19, 2023 · 5 comments · Fixed by #4094
Closed

Text Annotation of Bondary Event hidden behhind Sub-Process #4035

mschoe opened this issue Dec 19, 2023 · 5 comments · Fixed by #4094
Assignees
Labels
BPMN bug Something isn't working modeling spring cleaning Could be cleaned up one day ux
Milestone

Comments

@mschoe
Copy link
Member

mschoe commented Dec 19, 2023

Describe the bug

My text annotation is hidden when I add it to a boundary event which is attached to a sub-process
image

Steps to reproduce

  1. model a sub process
  2. add a boundary event to the bottom edge of the sub process
  3. add a text annotation

Expected behavior

text annotation is visible

Environment

  • Camunda Modeler Version: can be reproduced in Desktop and Web Modeler (8.4.0-alpha2)
  • Execution Platform: Camunda 8

Additional context

Potentially depends on bpmn-io/bpmn-js#2049.

@mschoe mschoe added the bug Something isn't working label Dec 19, 2023
@philippfromme philippfromme added the backlog Queued in backlog label Dec 19, 2023
@philippfromme
Copy link
Contributor

The reason is that the parent of the text annotation is the same as the boundary event's parent. It's basically the same case as this one:

image

@philippfromme
Copy link
Contributor

philippfromme commented Dec 19, 2023

Maybe text annotations should always be on top, like the associations connecting them.

@philippfromme philippfromme added the spring cleaning Could be cleaned up one day label Dec 19, 2023
@philippfromme
Copy link
Contributor

This issue is covered as part of bpmn-io/bpmn-js#2049 so I'll close it.

@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Dec 19, 2023
@nikku
Copy link
Member

nikku commented Dec 19, 2023

@philippfromme Let's have it open as distinct issues.

This one specifically would imply that text annotations are always on top, the other one may imply no auto-resizing for text annotations only.

@nikku nikku reopened this Dec 19, 2023
@nikku nikku added the backlog Queued in backlog label Dec 19, 2023
@nikku nikku added this to the M73 milestone Feb 2, 2024
@nikku nikku added fixed upstream Requires integration of upstream change and removed backlog Queued in backlog labels Feb 2, 2024
@nikku
Copy link
Member

nikku commented Feb 2, 2024

Text annotations will alway be rendered on top with [email protected]. Pending integration.

nikku added a commit that referenced this issue Feb 2, 2024
Closes #4035
Closes #3070
Closes #4070
Closes #4051
Closes #4037
Closes #3991
@nikku nikku mentioned this issue Feb 2, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 2, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Feb 2, 2024
nikku added a commit that referenced this issue Feb 2, 2024
Closes #4035
Closes #3070
Closes #4070
Closes #4051
Closes #4037
Closes #3991
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 2, 2024
nikku added a commit that referenced this issue Feb 5, 2024
Closes #4035
Closes #3070
Closes #4070
Closes #4051
Closes #4037
Closes #3991
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN bug Something isn't working modeling spring cleaning Could be cleaned up one day ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants