Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FEEL editor #394

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Update FEEL editor #394

merged 3 commits into from
Jan 24, 2025

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jan 24, 2025

Proposed Changes

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 24, 2025
@barmac
Copy link
Member

barmac commented Jan 24, 2025

I can reproduce the CI failure on my machine (MacOS). Let me have a look...

@barmac barmac force-pushed the update-feel-editor branch from 085cdc7 to 79736da Compare January 24, 2025 11:08
@barmac
Copy link
Member

barmac commented Jan 24, 2025

The tests are now fixed. They contained FEEL expressions which were formerly marked as syntax errors, but the expressions were proper esoteric FEEL 🙄

@philippfromme
Copy link
Contributor Author

Thank you @barmac. Ready for review.

@nikku nikku merged commit 03f4933 into main Jan 24, 2025
11 checks passed
@nikku nikku deleted the update-feel-editor branch January 24, 2025 14:17
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 24, 2025
@nikku
Copy link
Member

nikku commented Jan 24, 2025

Merged, as my language context work depends on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants