Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes the user draws a bit with the new color before the color picker change event fires #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion drawing-app/script.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,37 @@ let color = colorEl.value
let x
let y

let startColor
let points = []

canvas.addEventListener('mousedown', (e) => {
isPressed = true

x = e.offsetX
y = e.offsetY

startColor = color
points.push({x, y})
})

document.addEventListener('mouseup', (e) => {
isPressed = false

x = undefined
y = undefined
startColor = undefined
points = []
})

canvas.addEventListener('mousemove', (e) => {
if(isPressed) {
const x2 = e.offsetX
const y2 = e.offsetY

if (startColor) {
points.push({x: x2, y: y2})
}

drawCircle(x2, y2)
drawLine(x, y, x2, y2)

Expand All @@ -42,13 +54,15 @@ canvas.addEventListener('mousemove', (e) => {
})

function drawCircle(x, y) {
console.log('circle', x, y, color)
ctx.beginPath();
ctx.arc(x, y, size, 0, Math.PI * 2)
ctx.fillStyle = color
ctx.fill()
}

function drawLine(x1, y1, x2, y2) {
console.log('line', x1, y1, x2, y2, color)
ctx.beginPath()
ctx.moveTo(x1, y1)
ctx.lineTo(x2, y2)
Expand Down Expand Up @@ -81,6 +95,23 @@ decreaseBtn.addEventListener('click', () => {
updateSizeOnScreen()
})

colorEl.addEventListener('change', (e) => color = e.target.value)
colorEl.addEventListener('change', (e) => {
color = e.target.value

if (isPressed) {
console.log('color changed while drawing')
if (startColor !== color) {
console.log(`fixing ${points.length} dots from ${startColor} to ${color}`)
for (let i = 0; i < points.length - 1; i++) {
drawCircle(points[i].x, points[i].y)
drawLine(points[i].x, points[i].y, points[i + 1].x, points[i + 1].y)
drawCircle(points[i + 1].x, points[i + 1].y)
}
console.log('done fixing it')
startColor = color
points = []
}
}
})

clearEl.addEventListener('click', () => ctx.clearRect(0,0, canvas.width, canvas.height))