Add support for Ruby 3.0.0 #46
Conversation
pblesi
force-pushed
the
master
branch
2 times, most recently
from
79b6db7 to
a2c1ebf
Compare
|
@pblesi - this one now needs a merge conflict resolution due to gem upgrades. |
There was a problem hiding this comment.
👋 Thanks for making this update. The Braintree SDK team uses Runbook (via gist) to release our Ruby SDK, which recently bumps to support 2.6+. So this PR should also fix a current issue with our release script.
If you need any additional 👀 or help on it, let us know!
pblesi
force-pushed
the
master
branch
2 times, most recently
from
39645ed to
ed5d43e
Compare
There was a problem hiding this comment.
@pblesi ❤️ this work updating runbook. I left a few questions/comments around versioned testing and dependencies.
| - 2.4.6 | ||
| - 2.5.5 | ||
| - 2.6.3 | ||
| - 2.4.10 |
There was a problem hiding this comment.
the Ruby core community dropped support for versions below 2.6, I'm thinking we should drop any versions below 2.6, as well.
There was a problem hiding this comment.
I would prefer to continue to support these versions as long as it is not inconvenient. On the off chance that someone needs a feature from this version, but they find it difficult to upgrade their Ruby version, I want to be accommodating to their needs.
There was a problem hiding this comment.
Debian oldstable, still in lts, is ruby 2.3.3.
runbook.gemspec
Outdated
| @@ -42,7 +43,7 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.add_development_dependency "appraisal", "~> 2.2" | |||
| spec.add_development_dependency "aruba", "~> 0.14" | |||
| spec.add_development_dependency "bundler", "~> 1.15" | |||
| spec.add_development_dependency "bundler", ">= 2.2.0", "< 3.0" | |||
There was a problem hiding this comment.
Yeah, that makes sense to me. I can't recall why I expressed it this way. Will update.
In addition to adding support for Ruby 3.0.0, this commit also: * Adds support for Ruby 2.7.2 * Removes support for Ruby 2.2.10 * Adds support for Bundler < 3.0 * Drops support for Bundler < 2.2.0 * Adds a ci option to the project generator
This addresses issue: #40
In addition to adding support for Ruby 3.0.0, this commit does the
following: