Feature: Adapt menu options and icon depending on server running to better visualize status #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f server is running or not
andrerom
force-pushed
the
server_status_indication
branch
from
2f35e08 to
f99ff10
Compare
andrerom
changed the title
andrerom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #121
This improves usability by giving you a grey icon if server is not running, and a blue icon (the existing one) if server is running.
It also changes to trigger openFileInBrowser when clicking icon when server is running so you don't get error about that, but instead get what you expect.
Screenshoot: Server not running vs Server running:
Looking for feedback on approach before attempting to improve on test coverage.
UPDATE: Marked as Draft as this needs further work if anyone wants to pull this in, main issue is the state about php running or not can easily get out of date, there needs to be a way to check if it runs for sure. This is especially issue with several VS Code windows open with different paths PHP should start in.