Fix build with Bazel #549
Open
Fix build with Bazel #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building Rust applications with Bazel instead of cargo, typically a sandbox is in place, where each process invocation (rustc, build.rs program, etc.) runs in its own "root", where the view on the filesystem is the same, but the absolute paths are different. As a consequence, CARGO_MANIFEST_DIR differs between the invocation of build.rs and rustc. That means that absolute paths in the generated webgl_exts.rs don't work. Fortunately, the source files are relative to the CARGO_MANIFEST_DIR, which, while changing between invocations, remains valid.
tronical
added a commit
to slint-ui/slint
that referenced
this pull request
Jan 5, 2025
Use relative paths to CARGO_MANIFEST_DIR in build.rs. Patch is also submitted upstream at brendanzab/gl-rs#549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Rust applications with Bazel instead of cargo, typically a sandbox is in place, where each process invocation (rustc, build.rs program, etc.) runs in its own "root", where the view on the filesystem is the same, but the absolute paths are different. As a consequence, CARGO_MANIFEST_DIR differs between the invocation of build.rs and rustc.
That means that absolute paths in the generated webgl_exts.rs don't work. Fortunately, the source files are relative to the CARGO_MANIFEST_DIR, which, while changing between invocations, remains valid.