Handle new pandas versions, fix travis CI #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) The information on the batch should be a pd.Series the current behavior is that if the model is not defined, it will be created through the pd.DataFrame constructor, missing the index, which is later used in the funciton, leading to a KeyError 2) Remove the now deprecated iterkv -> iteritems 3) Cast n_array to integer In the current behavior, it can be a float and lead to the raise of a TypeError 3) Drop the use of the now deprecated reshape method raises a FutureWarning otherwise 4) Cleaner main 5) Fix travis CI
|
excellent! thank you. sounds like this closes #6 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current behavior is that if the model is not defined,
it will be created through the pd.DataFrame constructor, missing
the index, which is later used in the funciton, leading to a
KeyError
Remove the now deprecated iterkv -> iteritems
Cast n_array to integer
In the current behavior, it can be a float and lead to the
raise of a TypeError
raises a FutureWarning otherwise
Cleaner main
Fix travis CI