Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hangman: consistently handle eof #842

Merged
merged 1 commit into from
Nov 28, 2024
Merged

hangman: consistently handle eof #842

merged 1 commit into from
Nov 28, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 27, 2024

  • If you reach the end of a game and see the PLAY AGAIN prompt, eof will cause the program to terminate
  • Do the same if eof occurs after the GUESS A LETTER prompt; the NetBSD version handles this in getguess() [1]
  • test: echo sword > wordlist.txt && echo hi | perl hangman # now terminates
  1. http://cvsweb.netbsd.org/bsdweb.cgi/src/games/hangman/getguess.c?annotate=1.10

@mknos
hangman: consistently handle eof
13c1b40 
* If you reach the end of a game and see the PLAY AGAIN prompt, eof will cause the program to terminate
* Do the same if eof occurs after the GUESS A LETTER prompt; the NetBSD version handles this in getguess() [1]
* test: echo sword > wordlist.txt  && echo hi | perl hangman # now terminates 

1. http://cvsweb.netbsd.org/bsdweb.cgi/src/games/hangman/getguess.c?annotate=1.10
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: hangman The hangman program labels Nov 27, 2024
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 27, 2024 06:29 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12044957680

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 12040230006: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 059fa13 into briandfoy:master Nov 28, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: consistently handle eof when there is not a guess

@briandfoy briandfoy self-assigned this Nov 28, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Nov 28, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: hangman The hangman program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy