Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: disallow trailing '/' when setting filename #845

Merged
merged 1 commit into from
Nov 30, 2024
Merged

ed: disallow trailing '/' when setting filename #845

merged 1 commit into from
Nov 30, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 29, 2024

  • The usage "f abc/" is technically invalid because it would point to a directory
  • Subsequent "e" or "w" commands fail because ed does not operate on directories
  • GNU ed 1.20 added validation to prevent this usage; add it here because it would flag bad user input slightly earlier

@mknos
ed: prevent trailing '/' when setting filename
871e1a8 
* The usage "f abc/" is technically invalid because it would point to a directory
* Subsequent "e" or "w" commands fail because ed does not operate on directories
* GNU ed 1.20 added validation to prevent this usage; add it here because it would flag bad user input slightly earlier
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 29, 2024
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 05:19 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12079423300

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 12070185097: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy changed the title ed: prevent trailing '/' when setting filename ed: disallow trailing '/' when setting filename Nov 30, 2024
@briandfoy briandfoy merged commit 5f9377d into briandfoy:master Nov 30, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: disallow trailing '/' when setting filename

@briandfoy briandfoy self-assigned this Nov 30, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Nov 30, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy