Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkdir: compatible permissions #854

Merged
merged 1 commit into from
Dec 4, 2024
Merged

mkdir: compatible permissions #854

merged 1 commit into from
Dec 4, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 4, 2024

  • Doing a sync of function mod() from bin/chmod wasn't enough
  • Call mod() without a file argument because symbolic permissions should assume a default value of 0777
  • Now the mod() function diverges slightly from bin/chmod since $mode initialises to '777', not '000'
  • The 0755 permission applies when no -m option is given, but 0777 is used as base permission when constructing a symbolic permission (which is calculated relative to a base permission)
  • I tested some mkdir usages against OpenBSD...
  • test1: mkdir d ---> permissions of 0755
  • test2: mkdir -m a= d ---> no permissions (symbolic)
  • test3: mkdir -m 0 d ---> no permissions (numeric)
  • test4: mkdir -m u=rwx,g=rx ---> permissions of 0757 (o=7 because the default 0777 permission applies)
  • test5: mkdir -m u=rwx,g=rx,o= ---> permissions of 0750 (because 'o' is explicitly updated

@mknos
mkdir: compatible permissions
1447451 
* Doing a sync of function mod() from bin/chmod wasn't enough
* Call mod() without a file argument because symbolic permissions should assume a default value of 0777
* Now the mod() function diverges slightly from bin/chmod since $mode initialises to '777', not '000'
* I tested some mkdir usages against OpenBSD...
* test1: mkdir d ---> default permissions of 0755
* test2: mkdir -m a= d ---> no permissions (symbolic)
* test3: mkdir -m 0 d ---> no permissions (numeric)
* test4: mkdir -m u=rwx,g=rx ---> permissions of 0757 (o=7 because the default 0777 permission applies)
* test5: mkdir -m u=rwx,g=rx,o= ---> permissions of 0750 (because 'o' is explicitly updated
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: mkdir The mkdir program labels Dec 4, 2024
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 01:40 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12151375518

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12140302199: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Dec 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12151375518

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12140302199: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 4, 2024
@briandfoy briandfoy merged commit a227a2f into briandfoy:master Dec 4, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: default permissions are 0777 unless you specify them

@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: mkdir The mkdir program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy