Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tail: fix function params #864

Merged
merged 1 commit into from
Dec 6, 2024
Merged

tail: fix function params #864

merged 1 commit into from
Dec 6, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 6, 2024

  • When removing function prototypes I noticed two issues causing a fatal error thanks to strict.pm...
  • The first 2 args of tail_f() are supposed to be array-ref
  • The first 2 args of get_existing_files() are supposed to be array-ref
  • With this patch, "perl tail -f regular.txt" doesn't die, and follows changes to the file as expected
  • I guess with the old prototypes the parameters were being coerced, but that makes the code harder to audit
  • Move one statement so it appears after "use strict"

@mknos
tail: fix function params
9310c63 
* When removing function prototypes I noticed two issues causing a fatal error thanks to strict.pm...
* The first 2 args of tail_f() are supposed to be array-ref
* The first 2 args of get_existing_files() are supposed to be array-ref
* With this patch, "perl tail -f regular.txt" doesn't die, and follows changes to the file as expected
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tail The tail program labels Dec 6, 2024
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 03:10 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12192196059

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12185242343: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy merged commit 522cb76 into briandfoy:master Dec 6, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: some fixups to make strict happy

@briandfoy briandfoy self-assigned this Dec 6, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work Status: released there is a new release with this fix and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists Status: accepted The fix is accepted labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tail The tail program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy