Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

od: add -D option #939

Merged
merged 1 commit into from
Jan 31, 2025
Merged

od: add -D option #939

merged 1 commit into from
Jan 31, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 31, 2025

  • GNU and OpenBSD versions support -d for 2-byte unsigned decimal and -D for 4-byte unsigned decimal
  • This versions was missing -D; it's a shortcut option for -t u4
  • The OpenBSD manual incorrectly states that -D is an octal format[1]
  • The OpenBSD source confirms the format is unsigned decimal[2]
  1. http://man.openbsd.org/od
  2. https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/hexdump/odsyntax.c?annotate=1.28 (L127)

@mknos
od: add -D option
3d8af3d 
* GNU and OpenBSD versions support -d for 2-byte unsigned decimal and -D for 4-byte unsigned decimal
* This versions was missing -D; it's a shortcut option for -t u4
* The OpenBSD manual incorrectly states that -D is an octal format[1]
* The OpenBSD source confirms the format is unsigned decimal[2]

1. http://man.openbsd.org/od
2. https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/hexdump/odsyntax.c?annotate=1.28 (L127)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: od The od program labels Jan 31, 2025
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 31, 2025 14:37 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 31, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13074860017

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.389%
Totals Coverage Status
Change from base Build 13054078573: -0.7%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy self-assigned this Jan 31, 2025
@briandfoy briandfoy merged commit 8bc9163 into briandfoy:master Jan 31, 2025
21 of 23 checks passed
@briandfoy
Copy link
Owner

changes: add -D option as alias for -t u4 (four digit decimals)

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: od The od program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy