Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Contrast reserve #261

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

WimDeMeester
Copy link

@WimDeMeester WimDeMeester commented Dec 23, 2024

Adds the calculation of contrast reserve to PiFinder.
The value of the contrast reserve is shown in the object detail page:
2024-12-23 15_12_20-Luma core Display Emulator (piFinder)

Remarks:

  • As the SQM is not yet calculated by the PiFinder, I take a fixed value of 20.15 for the SQM.
  • The contrast reserve is just a number... For most users, this number does not mean anything. We still need to find out how to display the contrast reserve in a more meaningfull way
Contrast Reserve Visibility
< -0.2 Not visible
-0.2 < CR < 0.1 Questionable
0.1 < CR < 0.35 Difficult
0.35 < CR < 0.5 Quite difficult to see
0.5 < CR < 1.0 Easy to see
1.0 < CR Very easy to see

This pull request will solve #129

@jscheidtmann
Copy link
Contributor

I take it it's the number in the upper right?

Some ideas on the "just a number":

  • Use a bar graph: |===|=* | | |
  • Use a categorical scale: --, -, 0, +, ++
  • Zero to 5 stars: |*** |
  • ...

@WimDeMeester
Copy link
Author

I take it it's the number in the upper right?

Some ideas on the "just a number":

  • Use a bar graph: |===|=* | | |
  • Use a categorical scale: --, -, 0, +, ++
  • Zero to 5 stars: |*** |
  • ...

Good ideas! I will think a bit more about it during the christmas break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants