FE-249 add helper scripts to horsefish #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cripts in scripts/general - and adding find_loop.py
|
For the find_loop.py script - I think it would be helpful to print some indication that it at least ran successfully and found the string? Printing the line # where the string is found would be ideal. Otherwise, looks good to me! |
samanthahv
approved these changes
Jul 17, 2024
|
@samanthahv I made the requested changes and am going to go ahead and merge for the end of the sprint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added find_loop.py to horsefish along with a basic Python Docker image in which to run the script. Added usage in the script itself and verified that it will run with the instructions given in the main horsefish readme.
Also added to GitHub actions which will build and push updated images for the scripts/general folder on push to non-main branches and PRs to main.
Lastly, there is a bash script for building and pushing locally.