Skip to content

Commit

Permalink
CORE-69: Minor and patch updates - sbt-assembly to 2.3.1 - liquibase-…
Browse files Browse the repository at this point in the history
…core to 4.31.0 - workspace-manager-client to 0.254.1172-SNAPSHOT - swagger-parser-v3 to 2.1.25 - scalafmt-core to 3.8.5 - scala-library to 2.13.16 - sbt-scoverage to 2.3.0 - billing-profile-manager-client to 0.1.600-SNAPSHOT - sbt-scalafmt to 2.5.4 (#3169)

* CORE-69: Update billing-profile-manager-client from 0.1.598-SNAPSHOT to 0.1.600-SNAPSHOT

* CORE-69: Update workspace-manager-client from 0.254.1170-SNAPSHOT to 0.254.1172-SNAPSHOT

* CORE-69: Update sbt-assembly from 2.3.0 to 2.3.1

* CORE-69: Update swagger-parser-v3 from 2.1.24 to 2.1.25

* CORE-69: Update liquibase-core from 4.30.0 to 4.31.0

* CORE-69: Update scala-library from 2.13.15 to 2.13.16

* CORE-69: Update sbt-scalafmt from 2.5.2 to 2.5.4

* CORE-69: Update scalafmt-core from 3.8.4 to 3.8.5

* CORE-69: Update sbt-scoverage from 2.2.2 to 2.3.0

* update scala image for docker

---------

Co-authored-by: Bria Morgan <[email protected]>
  • Loading branch information
broadbot and calypsomatic authored Jan 21, 2025
1 parent 9c4e0f9 commit 4a1765d
Show file tree
Hide file tree
Showing 12 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/consumer_contract_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
-v jar-cache:/root/.ivy \
-v jar-cache:/root/.ivy2 \
-w /working \
sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.15 \
sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.16 \
bash -c "git config --global --add safe.directory /working && sbt -J-Xmx2g -J-XX:+UseG1GC \"project pact4s\" clean \"testOnly org.broadinstitute.dsde.rawls.consumer.*\""
- name: Output consumer contract as non-breaking base64 string
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify_consumer_pacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ jobs:
-e POSTGRES_READ_URL=localhost:5432 \
-e POSTGRES_USERNAME=rawls-test \
-e POSTGRES_PASSWORD=rawls-test \
sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.15 \
sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.16 \
bash -c "git config --global --add safe.directory /working && sbt -J-Xmx2g -J-XX:+UseG1GC \"project pact4s\" clean coverage \"testOnly org.broadinstitute.dsde.rawls.provider.*\" coverageReport"
can-i-deploy: # The can-i-deploy job will run as a result of a Rawls PR. It reports the pact verification statuses on all deployed environments.
Expand Down
2 changes: 1 addition & 1 deletion .scalafmt.conf
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version = 3.8.4
version = 3.8.5
align = none
align.openParenCallSite = true
align.openParenDefnSite = true
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# TODO: Replace build script with multi-stage Dockerfile that builds its own JAR
# FROM sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.15 as jar-builder
# FROM sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.16 as jar-builder
# ...build JAR...
# FROM us.gcr.io/broad-dsp-gcr-public/base/jre:17-debian
# COPY --from=jar-builder ./rawls*.jar /rawls
Expand Down
2 changes: 1 addition & 1 deletion automation/Dockerfile-tests
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.15
FROM sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.16

COPY src /app/src
COPY test.sh /app
Expand Down
2 changes: 1 addition & 1 deletion automation/project/Settings.scala
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ object Settings {
val commonSettings =
commonBuildSettings ++ testSettings ++ List(
organization := "org.broadinstitute.dsde.firecloud",
scalaVersion := "2.13.15",
scalaVersion := "2.13.16",
resolvers ++= commonResolvers,
scalacOptions ++= commonCompilerSettings
)
Expand Down
4 changes: 2 additions & 2 deletions docker/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ function make_jar()
# TODO: DOCKER_TAG hack until JAR build migrates to Dockerfile. Tell SBT to name the JAR
# `rawls-assembly-local-SNAP.jar` instead of including the commit hash. Otherwise we get
# an explosion of JARs that all get copied to the image; and which one runs is undefined.
DOCKER_RUN="$DOCKER_RUN -e DOCKER_TAG=local -e GIT_COMMIT -e BUILD_NUMBER -v $PWD:/working -v sbt-cache:/root/.sbt -v jar-cache:/root/.ivy2 -v coursier-cache:/root/.cache/coursier sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.15 /working/docker/clean_install.sh /working"
DOCKER_RUN="$DOCKER_RUN -e DOCKER_TAG=local -e GIT_COMMIT -e BUILD_NUMBER -v $PWD:/working -v sbt-cache:/root/.sbt -v jar-cache:/root/.ivy2 -v coursier-cache:/root/.cache/coursier sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.16 /working/docker/clean_install.sh /working"

JAR_CMD=$($DOCKER_RUN 1>&2)
EXIT_CODE=$?
Expand All @@ -116,7 +116,7 @@ function artifactory_push()
ARTIFACTORY_USERNAME=dsdejenkins
ARTIFACTORY_PASSWORD=$(docker run -e VAULT_TOKEN=$VAULT_TOKEN broadinstitute/dsde-toolbox vault read -field=password secret/dsp/accts/artifactory/dsdejenkins)
echo "Publishing to artifactory..."
docker run --rm -e GIT_HASH=$GIT_HASH -v $PWD:/$PROJECT -v sbt-cache:/root/.sbt -v jar-cache:/root/.ivy2 -v coursier-cache:/root/.cache/coursier -w="/$PROJECT" -e ARTIFACTORY_USERNAME=$ARTIFACTORY_USERNAME -e ARTIFACTORY_PASSWORD=$ARTIFACTORY_PASSWORD sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.15 /$PROJECT/core/src/bin/publishSnapshot.sh
docker run --rm -e GIT_HASH=$GIT_HASH -v $PWD:/$PROJECT -v sbt-cache:/root/.sbt -v jar-cache:/root/.ivy2 -v coursier-cache:/root/.cache/coursier -w="/$PROJECT" -e ARTIFACTORY_USERNAME=$ARTIFACTORY_USERNAME -e ARTIFACTORY_PASSWORD=$ARTIFACTORY_PASSWORD sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.16 /$PROJECT/core/src/bin/publishSnapshot.sh
}

function docker_cmd()
Expand Down
2 changes: 1 addition & 1 deletion docker/build_jar.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
set -e

# make jar. cache sbt dependencies. capture output and stop db before returning.
docker run --rm -e DOCKER_TAG -e GIT_COMMIT -e BUILD_NUMBER -v $PWD:/working -v sbt-cache:/root/.sbt -v jar-cache:/root/.ivy2 -v coursier-cache:/root/.cache/coursier sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.15 /working/docker/clean_install.sh /working
docker run --rm -e DOCKER_TAG -e GIT_COMMIT -e BUILD_NUMBER -v $PWD:/working -v sbt-cache:/root/.sbt -v jar-cache:/root/.ivy2 -v coursier-cache:/root/.cache/coursier sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.16 /working/docker/clean_install.sh /working
EXIT_CODE=$?

if [ $EXIT_CODE != 0 ]; then
Expand Down
2 changes: 1 addition & 1 deletion local-dev/templates/docker-rsync-local-rawls.sh
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ start_server () {
-e JAVA_OPTS="$JAVA_OPTS" \
-e GOOGLE_APPLICATION_CREDENTIALS='/etc/rawls-account.json' \
-e GIT_HASH=$GIT_HASH \
sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.15 \
sbtscala/scala-sbt:eclipse-temurin-17.0.13_11_1.10.7_2.13.16 \
bash -c "git config --global --add safe.directory /app && sbt clean \~reStart"

docker cp config/rawls-account.pem rawls-sbt:/etc/rawls-account.pem
Expand Down
8 changes: 4 additions & 4 deletions project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ object Dependencies {
val antlrParser: ModuleID = "org.antlr" % "antlr4-runtime" % "4.13.2"
// protobuf is only need to use the MySQL X DevAPI which we don't. exclude it to avoid interference with Google client libraries
val mysqlConnector: ModuleID = "com.mysql" % "mysql-connector-j" % "9.1.0" exclude("com.google.protobuf", "protobuf-java")
val liquibaseCore: ModuleID = "org.liquibase" % "liquibase-core" % "4.30.0"
val liquibaseCore: ModuleID = "org.liquibase" % "liquibase-core" % "4.31.0"
val jakartaWsRs: ModuleID = "jakarta.ws.rs" % "jakarta.ws.rs-api" % "4.0.0"
val jerseyJnhConnector: ModuleID = "org.glassfish.jersey.connectors" % "jersey-jnh-connector" % "3.1.10"

Expand Down Expand Up @@ -127,10 +127,10 @@ object Dependencies {
// "Terra Common Lib" Exclusions:
def tclExclusions(m: ModuleID): ModuleID = m.excludeAll(excludeSpringBoot, excludeSpringAop, excludeSpringData, excludeSpringFramework, excludeOpenCensus, excludeGoogleFindBugs, excludeBroadWorkbench, excludePostgresql, excludeSnakeyaml, excludeSlf4j)

val workspaceManager = clientLibExclusions("bio.terra" % "workspace-manager-client" % "0.254.1170-SNAPSHOT")
val workspaceManager = clientLibExclusions("bio.terra" % "workspace-manager-client" % "0.254.1172-SNAPSHOT")
val dataRepo = clientLibExclusions("bio.terra" % "datarepo-jakarta-client" % "1.593.0-SNAPSHOT")
val resourceBufferService = clientLibExclusions("bio.terra" % "terra-resource-buffer-client" % "0.198.42-SNAPSHOT")
val billingProfileManager = clientLibExclusions("bio.terra" % "billing-profile-manager-client" % "0.1.598-SNAPSHOT")
val billingProfileManager = clientLibExclusions("bio.terra" % "billing-profile-manager-client" % "0.1.600-SNAPSHOT")
val terraCommonLib = tclExclusions(clientLibExclusions("bio.terra" % "terra-common-lib" % "0.1.23-SNAPSHOT" classifier "plain"))
val sam: ModuleID = clientLibExclusions("org.broadinstitute.dsde.workbench" %% "sam-client" % "v0.0.343")
val leonardo: ModuleID = "org.broadinstitute.dsde.workbench" % "leonardo-client_2.13" % "1.3.6-2e87300"
Expand All @@ -147,7 +147,7 @@ object Dependencies {
val kindProjector = compilerPlugin(("org.typelevel" %% "kind-projector" % "0.13.3").cross(CrossVersion.full))
val betterMonadicFor = compilerPlugin("com.olegpy" %% "better-monadic-for" % "0.3.1")

val openApiParser: ModuleID = "io.swagger.parser.v3" % "swagger-parser-v3" % "2.1.24"
val openApiParser: ModuleID = "io.swagger.parser.v3" % "swagger-parser-v3" % "2.1.25"

// Overrides for transitive dependencies. These apply - via Settings.scala - to all projects in this codebase.
// These are overrides only; if the direct dependencies stop including any of these, they will not be included
Expand Down
2 changes: 1 addition & 1 deletion project/Settings.scala
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ object Settings {
)

// When updating this, also update Docker image (https://hub.docker.com/r/sbtscala/scala-sbt/tags)
val scala213 = "2.13.15"
val scala213 = "2.13.16"

// common settings for all sbt subprojects, without enforcing that a database is present (for tests)
val commonSettingsWithoutDb =
Expand Down
6 changes: 3 additions & 3 deletions project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.3.0")
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.3.1")

addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.2.2")
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.3.0")

addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.2")
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.4")

addSbtPlugin("com.simplytyped" % "sbt-antlr4" % "0.8.3")

Expand Down

0 comments on commit 4a1765d

Please sign in to comment.