Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDO-3190 Update Azure e2e test #2643

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Conversation

knapii-developments
Copy link
Contributor

@knapii-developments knapii-developments commented Dec 1, 2023

Ticket: https://broadworkbench.atlassian.net/browse/DDO-3190
Updating Azure E2E tests to fix failures.


PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and update rawls-model in Orchestration's dependencies.
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@@ -212,14 +212,13 @@ jobs:
ref: refs/heads/main
token: ${{ env.TOKEN }}
inputs: '{
"additional-args": "{\"logging\":\"true\",\"java-version\":\"17\",\"billing-project\":\"\"}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't need to pass the billing-project?

${{ needs.params-gen.outputs.project-name }}

Copy link
Contributor

@cahrens cahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbing assuming a test run passes.

@knapii-developments knapii-developments merged commit 73151ec into develop Dec 1, 2023
19 of 21 checks passed
@knapii-developments knapii-developments deleted the DDO-3190-azuree2e branch December 1, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants