Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJ-1498: tracing and isolation level for updateStatisticsCache #2652

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Dec 5, 2023

Ticket: https://broadworkbench.atlassian.net/browse/AJ-1498

More optimizations and debuggability for the entity statistics cache.

  • explicitly set the transactions in updateStatisticsCache to be ReadCommitted. This is probably moot, since this method is only called from sweep(), and we set the outer transaction in sweep() to ReadCommitted in AJ-1498: reduce transaction isolation level for entity metadata #2650. But, it helps for code readability and future-proofing.
  • move the declaration of ReadCommitted to a trait-level variable for consistency
  • add more detail to the tracing spans under sweep(). This is likely to confirm previous knowledge that getAttrNamesAndEntityTypes is slow, but it'll be good to see empirical data.

Reviewer: I suggest ignoring whitespace in the diff; auto-formatter changed a bunch


PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and update rawls-model in Orchestration's dependencies.
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@davidangb davidangb marked this pull request as ready for review December 5, 2023 21:05
@davidangb davidangb changed the title AJ-1498: set inner transaction tag to read committed too AJ-1498: tracing and isolation level for updateStatisticsCache Dec 5, 2023
@davidangb
Copy link
Contributor Author

@davidangb
Copy link
Contributor Author

fiab-start failed with a 503 from Sam. Jenkins retest.

@davidangb davidangb merged commit d13c1ba into develop Dec 5, 2023
10 checks passed
@davidangb davidangb deleted the da_queryOptimizations branch December 5, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants