[WOR-1348] Fix GCP Enhanced Bucket Monitoring on Clone #2654
Conversation
cahrens
changed the title
| testData.testProject1Name.value, | ||
| baseWorkspaceName, | ||
| Map.empty, | ||
| authorizationDomain = Option(Set(testData.dbGapAuthorizedUsersGroup)) |
There was a problem hiding this comment.
I think the auth domain case worked before, and what failed was when the original workspace had "enahncedBucketLogging" set to true but no auth domains.
There was a problem hiding this comment.
Intersting, I got a test failure when I removed my fix, and a pass when I included it.
There was a problem hiding this comment.
Hmmm, the bug we are seeing from terra-ui is specific to not checking "enhancedBucketLogging" but that's probably because we force "enhancedBucketLogging" to be true for workspaces that have an auth domain. So if we didn't send the option in the clone request I guess we would see the bug then also.
There was a problem hiding this comment.
updated the test case to be even clearer
|
jenkins retest |
cahrens
requested review from
a team,
marctalbott and
aherbst-broad
and removed request for
a team
|
jenkins retest |
Ticket: https://broadworkbench.atlassian.net/browse/WOR-1348
Rawls needs to look at the source workspace bucket to determine a cloned workspace's enhanced bucket monitoring, not the destination bucket, which can happen if the destination workspace has a bucket name.
PR checklist
model/, then you should publish a new officialrawls-modeland updaterawls-modelin Orchestration's dependencies.